Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add new node builder mono-module #748

Merged
merged 4 commits into from
Oct 17, 2023
Merged

add new node builder mono-module #748

merged 4 commits into from
Oct 17, 2023

Conversation

hsjobeki
Copy link
Contributor

@hsjobeki hsjobeki commented Oct 17, 2023 •
edited
Loading

Works but has limitations.

Todo in this PR

  • add simple usage example

Todo in future PRs:

  • Install only dependencies, not all lock entries.
  • Differentiate between dev and prod dependencies.
  • Allow to run install scripts
  • Proper lifecycle management for all dependecies, not just the roots.
  • Add option to the builder for symlinked trees. (Copy is default)
  • Add our custom unpackPhase to fix issues with some npm tarballs

@hsjobeki hsjobeki requested a review from DavHau October 17, 2023 13:13
@hsjobeki hsjobeki force-pushed the feat/node-v3-builder branch 2 times, most recently from 3afaad0 to b91dc7c Compare October 17, 2023 18:42
@hsjobeki hsjobeki force-pushed the feat/node-v3-builder branch from b91dc7c to 93b3829 Compare October 17, 2023 18:51
@DavHau DavHau merged commit 419d6f0 into nix-community:main Oct 17, 2023
2 checks passed
@hsjobeki hsjobeki mentioned this pull request Oct 18, 2023
Merged
chaoflow pushed a commit to chaoflow/dream2nix that referenced this pull request Nov 16, 2024
@hsjobeki @DavHau @chaoflow
add new node builder mono-module (nix-community#748)
cbb42cf 
* add new node builder mono-module

* add example

* nodejs-builder-v3: rename to WIP-nodejs-builder-v3

* fix tests

---------

Co-authored-by: DavHau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavHau DavHau Awaiting requested review from DavHau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsjobeki @DavHau