Fix spago lock script #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mergify rebase |
✅ Branch has been successfully rebased |
|
How about just downloading the required revision via tarball? |
|
Yeah unfortunately that solution isn't possible here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@DavHau I picked this up again and realized that recreating the lockfile then the build failed because now package-set is too new (we were always fetching
master).Unfortunately that repo doesn't have tags that includes package set versions (like
42.1.0) so now the entire repo is fetched instead of the tarball and then I checkout the correct branch which is discovered checking commit messages.There could be better ways but I believe it's enough for the lock script.