-
-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support old PHP versions #482
base: main
Are you sure you want to change the base?
Conversation
Thanks for that. @tinybeachthor pinging you in case you'd like tor review this. |
# php with required extensions | ||
php = | ||
if satisfies pkgs.php81.version subsystemAttrs.phpSemver | ||
phpPackages = l.attrValues inputs.phps.packages.x86_64-linux; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
phpPackages = l.attrValues inputs.phps.packages.x86_64-linux; | |
phpPackages = l.attrValues inputs.phps.packages.x86_64-linux; | |
phpPackages = l.attrValues (import inputs.phps).packages.x86_64-linux; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For my own understanding, what does import do here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of treating inputs.php
like a flake, it treats it as a path and imports it. Currently we have a failing CI tests, because under some circumstances inputs.php is a path and not a flake. This is buggy behavior in our backward compat mechanism which I don't intend to fix anymore in favor of the upcoming v1 API changes.
# php with required extensions | ||
php = | ||
if satisfies pkgs.php81.version subsystemAttrs.phpSemver | ||
phpPackages = l.attrValues inputs.phps.packages.x86_64-linux; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
phpPackages = l.attrValues inputs.phps.packages.x86_64-linux; | |
phpPackages = l.attrValues inputs.phps.packages.x86_64-linux; | |
phpPackages = l.attrValues (import inputs.phps).packages.x86_64-linux; |
# php with required extensions | ||
php = | ||
if satisfies pkgs.php81.version subsystemAttrs.phpSemver | ||
phpPackages = l.attrValues inputs.phps.packages.x86_64-linux; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably does not make much difference, maybe passing system
attribute here instead of hard-coding x86_64-linux
.
|
Will php still work with the V1 api? |
As suggested in #240, adds support for all stable php versions from https://github.com/fossar/nix-phps