Add generic-device-plugin package and module
#49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MagicRB
force-pushed
the
generic-device-plugin
branch
from
c38cbc2 to
b45b8d1
Compare
MagicRB
force-pushed
the
generic-device-plugin
branch
from
b45b8d1 to
de21981
Compare
MagicRB
force-pushed
the
generic-device-plugin
branch
9 times, most recently
from
09f5729 to
c589f89
Compare
Signed-off-by: magic_rb <[email protected]>
Signed-off-by: magic_rb <[email protected]>
Signed-off-by: magic_rb <[email protected]>
MagicRB
force-pushed
the
generic-device-plugin
branch
from
c589f89 to
88b2366
Compare
|
@pizzapim ready for review |
pizzapim
reviewed
Jan 1, 2025
| ''; | ||
| }; | ||
| }; | ||
| user = nglib.mkUserOption "generic-device-plugin" "User to run `generic-device-plugin` as."; |
There was a problem hiding this comment.
Can we instead use the user and group options under config.init.services.generic-device-plugin? Also I think the user and group are currently unused?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verified to work inside my dotfiles and kubernetes cluster.