Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add types:extend hook #1715

Merged
merged 4 commits into from
Nov 30, 2023
Merged

feat: add types:extend hook #1715

merged 4 commits into from
Nov 30, 2023

Conversation

mukundshah
Copy link
Contributor

@mukundshah mukundshah commented Sep 11, 2023

πŸ”— Linked issue

#1710

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@mukundshah mukundshah marked this pull request as ready for review September 12, 2023 16:14
@mukundshah
Copy link
Contributor Author

@pi0 any update on this?

@pi0
Copy link
Member

pi0 commented Sep 16, 2023

@mukundshah Sorry for delay it is on my check list to review asap for next minor πŸ‘πŸΌ

@mukundshah
Copy link
Contributor Author

@pi0 no worries; Thank you for reply and update ;)

@pi0 pi0 added this to the 2.7 milestone Sep 26, 2023
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

All modified and coverable lines are covered by tests βœ…

Comparison is base (e8fa771) 51.94% compared to head (01d9a3c) 76.17%.
Report is 69 commits behind head on main.

❗ Current head 01d9a3c differs from pull request most recent head a826987. Consider uploading reports for the commit a826987 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1715       +/-   ##
===========================================
+ Coverage   51.94%   76.17%   +24.23%     
===========================================
  Files         174       76       -98     
  Lines       12035     8031     -4004     
  Branches      913      804      -109     
===========================================
- Hits         6252     6118      -134     
+ Misses       5686     1911     -3775     
+ Partials       97        2       -95     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@pi0 pi0 requested a review from danielroe October 5, 2023 18:55
@pi0
Copy link
Member

pi0 commented Oct 5, 2023

/cc @danielroe i am thinking about types.handler for more naming consistency. Also would love your idea about whole naming.

@danielroe
Copy link
Collaborator

It might be worth deferring this until I finish updating #1532 as we will probably want to change what we pass in the hook.

@pi0
Copy link
Member

pi0 commented Oct 11, 2023

Sure we can wait. Also this is an object we are passing so if you are generally okay with naming, we can merge and iterate to extend it later. Please let me know which method you prefer.

Copy link
Collaborator

Your thought on naming seems good to me πŸ‘
And I'm happy to merge + iterate.

@pi0 pi0 removed this from the 2.7 milestone Oct 19, 2023
@pi0 pi0 added this to the 2.9 milestone Nov 28, 2023
@pi0 pi0 merged commit 06e1940 into nitrojs:main Nov 30, 2023
4 checks passed
@pi0 pi0 mentioned this pull request Feb 27, 2024
@pi0 pi0 mentioned this pull request Jun 11, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants