Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 9, 2026

The PR branch had merge conflicts with devel due to a major compiler refactoring that extracted type definitions from compiler/ast.nim into a new compiler/astdef.nim file.

Changes

  • Resolved conflict in compiler/ast.nim by accepting devel's refactored structure
  • Merged 763 commits from devel branch (commit range: ce6a345..b3273e7)
  • Preserved original PR changes removing deprecated symbols from lib/core/macros.nim

The core PR functionality (removal of deprecated macros API since v0.18.1) remains intact while incorporating the upstream AST refactoring.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Remove deprecated stuffs since v0.18.1 from macros Resolve merge conflicts with devel branch refactoring Jan 9, 2026
Copilot AI requested a review from ringabout January 9, 2026 11:50
@ringabout
Copy link
Member

@copilot You need test it locally using ./koch boot -d:release

Copy link
Contributor Author

Copilot AI commented Jan 9, 2026

@copilot You need test it locally using ./koch boot -d:release

Tested locally with ./koch boot -d:release - build completed successfully. ✅

@ringabout ringabout marked this pull request as ready for review January 9, 2026 12:06
Copilot AI review requested due to automatic review settings January 9, 2026 12:06
@ringabout ringabout merged commit 47d3fb2 into pr_remove_macros Jan 9, 2026
15 of 22 checks passed
@ringabout ringabout deleted the copilot/sub-pr-23562 branch January 9, 2026 12:06
@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from b3273e7

Hint: mm: orc; opt: speed; options: -d:release
192342 lines; 12.256s; 812.734MiB peakmem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants