rework sqlparse foreignkey ast & renderer a bit #25147
Closed
+35
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjsir911
force-pushed
the
m/parsesql-render-foreign-fix
branch
2 times, most recently
from
79cd09a to
7b49951
Compare
mjsir911
changed the title
mjsir911
force-pushed
the
m/parsesql-render-foreign-fix
branch
from
7b49951 to
bdc199b
Compare
Fixes nim-lang#25146 This is a breaking change since it messes with the AST a little bit to go from: nkForeignKey nkIdent artist_id_artist nkReferences nkCall nkIdent artist nkIdent artist_id to nkForeignKey nkColumnList nkIdent artist_id_artist nkReferences nkIdent artist nkColumnList nkIdent artist_id Which I honestly feel fine/good about, especially considering it lines up closer to https://www.sqlite.org/syntax/table-constraint.html + https://www.sqlite.org/syntax/foreign-key-clause.html & represents the constraint columnes & referenced columns as potential lists, as opposed to calls as it was before (why was it parsing this as a call? I see why but also it makes no sense)
|
Ormin also had to fork parsesql, time to move it into a Nimble package of its own. There you can apply this patch then. Ping @ringabout |
|
progress: #25156 |
|
Apply it at our new Nimble package please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25146
This is a breaking change since it messes with the AST a little bit to go from:
to
Which I honestly feel fine/good about, especially considering it lines up closer to https://www.sqlite.org/syntax/table-constraint.html + https://www.sqlite.org/syntax/foreign-key-clause.html & represents the constraint columnes & referenced columns as potential lists, as opposed to calls as it was before (why was it parsing this as a call? I see why but also it makes no sense)