Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assertion failures (on debug builds) issue #131

Open
LegendaryGuard opened this issue Oct 25, 2022 · 16 comments
Open

Assertion failures (on debug builds) issue #131

LegendaryGuard opened this issue Oct 25, 2022 · 16 comments

Comments

@LegendaryGuard
Copy link
Contributor

LegendaryGuard commented Oct 25, 2022

EDIT: I tried on some Windows PCs using HL2 non-steam version, the game isn't loading, checking in the Task Manager, when trying to launch, in a matter of milliseconds, the process status is suspended and after suddenly closes.


The other issues were a bit related to setup the game base correctly and due to the lack of knowledge about how the game base should work. Also about the debug build files while assertion errors are displayed (it isn't really troublesome, it's used for debugging checks, I think).

OLD ISSUE EDIT: Full edit. More info: #131 (comment)

I tried with HL2 non steam version one. No matter how many times you replace the compiled dlls and hl2_launcher.exe files, using with this symlink:

C:\Users\user\Desktop\backup_hl2_nosteam_nillerusr\hl2.exe -nosteam -insecure -console -windowed -w 1280 -h 720 -allowdebug +developer 5 +net_graph 2


The same HL2 non steam version using debug build pop-ups an assertion failure:
Assertion Failed: ctx.m_eAction == k_ECatchAndWriteMiniDumpAbort

assertionfailure


Assertion failures happen with debug builds, these message errors can be pretty annoying for some user who wants to debug the engine.

ATTENTION!!
IMPORTANT NOTE: In Windows, don't use the compiled SDL.dll from lib/win32/amd64, looks corrupted and the game won't load! Use the compiled SDL.dll from lib/win32/x86.

@LegendaryGuard
Copy link
Contributor Author

LegendaryGuard commented Oct 25, 2022

More info. I debugged with Visual Studio 2022 IDE in this another Windows PC with Intel Core i5. Doing the following:
Select Debug > Attach to Process (or press Ctrl+Alt+P in VS) > use the Attach to Process dialog to attach the debugger to the process (in that case select the "launcher.exe" or "hl2_launcher.exe". That's it, the compiled exe from the project).
Reference: #87 (comment)



It's telling something in materialsystem/cmaterialsystem.cpp, not sure about the exception here though.

vsdebughl2assertionsourcevrerrors

@magisk666
Copy link

Maybe there is a unique adaptation to AMD's CPU?

@LegendaryGuard
Copy link
Contributor Author

Maybe there is a unique adaptation to AMD's CPU?

P.D. This isn't CPU issue. Worked when I was playing without the compiled dlls and launcher.exe files and using the downloaded non steam ones on this another Windows PC.

Worked fine in some PCs with non steam version.

@magisk666
Copy link

Ha ha, just kidding

@LegendaryGuard
Copy link
Contributor Author

Dumb question: should be labeled as "non-steam" to tag this kind of issue?

@LegendaryGuard
Copy link
Contributor Author

LegendaryGuard commented Nov 3, 2022

I just checked deeply, non steam version still doesn't seem to work using the compiled files. Gonna to re-edit the issue, it isn't related to different Windows PCs, that happens all PCs.
By the other hand, I used other experimental project about non steam version, I'm talking about other repositories, "cool source engine" and "Quiver Source Engine 2007", worked as expected.
I don't know how worked for non steam version and without assertion failures.

@LegendaryGuard LegendaryGuard changed the title Assertion failure and sourcevr.dll error on another Windows PC Assertion failure and sourcevr.dll error on Windows Nov 3, 2022
@LegendaryGuard
Copy link
Contributor Author

LegendaryGuard commented Nov 4, 2022

In the following test, I used with waf.bat configure -T debug and waf.bat install.
After sourcevr.dll error window 3 times pop-up, appears this window:

image

This indicates the Assert tells what is happening with the source code file at that line.
If you press "Ignore All Asserts", the game will continue as if nothing had happened.

I modified code outputs to compare my compiled files to the other ones. I know that this cvar and this customized "Unknown command" message don't exist in the repository, I added just to test.

image

Curiously, during the gameplay, any achievement can be obtained legally (works as should):

image

I can't believe that after assertion failures, the game works pretty well, although there are assertion errors in the console messages from left corner (red ones). This should be fixed for sake, nonetheless.

@LegendaryGuard
Copy link
Contributor Author

Here the full log: engine.log

@LegendaryGuard
Copy link
Contributor Author

LegendaryGuard commented Nov 4, 2022

Update: when using waf.bat configure -T release and waf.bat install (compiling a release build),
only appears the sourcevr.dll error window popping up 3 times, after that (pressing OK 3 times to these error windows), the game loads quickly without assertion failures. No assertion errors are displayed in the console and left corner messages.
I update the description above, assertion failures happens with debug builds, that should be fixed as I said before, these message errors can be pretty annoying for some user who wants to debug the engine.

image

@LegendaryGuard LegendaryGuard changed the title Assertion failure and sourcevr.dll error on Windows Assertion failures (on debug builds) and sourcevr.dll error on Windows Nov 4, 2022
@EnderZip
Copy link

EnderZip commented Nov 5, 2022

Delete sourcevr.dll or comment out the part that loads it

@LegendaryGuard
Copy link
Contributor Author

LegendaryGuard commented Nov 5, 2022

Delete sourcevr.dll or comment out the part that loads it

Done. Works and doesn't display that error. That sourcevr.dll isn't from nillerusr repository compiled files, it's downloaded from that non-steam version game.

I'll modify the description to remove about that and leave assertion errors info.

@LegendaryGuard LegendaryGuard changed the title Assertion failures (on debug builds) and sourcevr.dll error on Windows Assertion failures (on debug builds) on Windows Nov 5, 2022
@LegendaryGuard
Copy link
Contributor Author

LegendaryGuard commented Nov 5, 2022

Collecting all assertion errors using the debug build, also note, these are the same displaying errors in the game console output:

filesystem/filetracker.cpp : line 103:

image

tier1/utlbuffer.cpp : line 728:

image

game/server/baseentity.cpp : line 3371:

image

tier1/datamanager.cpp : line 203:

image





In the game console about game/server/baseentity.cpp has differents outputs (full log):
engine.log

@EnderZip
Copy link

EnderZip commented Nov 5, 2022

There is literally no need to fix these asserts, they are harmless. If you don't want to see them compile on release.

@LegendaryGuard
Copy link
Contributor Author

LegendaryGuard commented Nov 5, 2022

I've to warn that the wrong compiled SDL.dll (from lib/win32/amd64) won't load the game on Windows. Use the compiled SDL.dll from lib/win32/x86 instead!

IIRC, the amd64 (64-bits) version on Windows still isn't available as HappyDOGE and others told.

@LegendaryGuard
Copy link
Contributor Author

Gotta rename the issue instead creating a new one. There's a problem when trying to run into different PCs.
I'll need a full check, not easy as I think though.

@LegendaryGuard LegendaryGuard changed the title Assertion failures (on debug builds) on Windows Non-steam client isn't working on some Windows PCs Nov 8, 2022
@LegendaryGuard LegendaryGuard changed the title Non-steam client isn't working on some Windows PCs Non-steam version game isn't loading on some Windows PCs Nov 8, 2022
@LegendaryGuard LegendaryGuard changed the title Non-steam version game isn't loading on some Windows PCs Make source engine work without steam Nov 10, 2022
@LegendaryGuard
Copy link
Contributor Author

I've come to the conclusion that this issue will be like a pending task.
It should work without steam, even if you prefer with / without.

@LegendaryGuard LegendaryGuard changed the title Make source engine work without steam Make source engine work without steam (also "with" if users prefer) Nov 10, 2022
@LegendaryGuard LegendaryGuard changed the title Make source engine work without steam (also "with" if users prefer) Make source engine work without steam (also "with" if users prefer). Old issue: Assertion failures (on debug builds) Nov 15, 2022
@LegendaryGuard LegendaryGuard changed the title Make source engine work without steam (also "with" if users prefer). Old issue: Assertion failures (on debug builds) Make source engine work without steam (also "with" if users prefer) + Assertion failures (on debug builds) issue Nov 28, 2022
@nillerusr nillerusr changed the title Make source engine work without steam (also "with" if users prefer) + Assertion failures (on debug builds) issue Assertion failures (on debug builds) issue Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants