Draft
Conversation
Philoul
changed the title
Philoul
force-pushed
the
Todo/insulin_concentration_compose
branch
3 times, most recently
from
6bdc1ce to
8e35489
Compare
Philoul
force-pushed
the
Todo/insulin_concentration_compose
branch
from
8e35489 to
3000c0a
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I propose this new starting point (I started from a working branch, and reorganized all the modification on 8 commits, each modified file is within only one of these 8 commits).
1- Infrastructure and database (v32, iCfg, new Interfaces for PumpRate, PumpInsulin, uel update, ...)
2- Profile updates (dia removal, add iCfg management within EffectiveProfile, ...)
3- Infra Pump, PumpSync and Bolus (add the new Layer including PumpWithConcentration, ...)
4- Pump Driver migration (all modifications on Pump driver to manage profile, PumpInsulin... is grouped within this commit)
5- Algo APS, Iob/Cob an automation, new management of IOB calculation with iCfg included within boluses
6- Insulin Plugin refactoring (one single plugin, InsulinSwitchDialog and ConcentrationDialog to manage switches)
7- update of all remaining plugins, and user interface
8- one latest commit to fix all (I hope) tests (probably the biggest commit due to number of tests impacted)
This has been done to facilitate review by theme, hope it will help. So all these commits work together (I didn't try to build intermediate steps but it will probably failed due to all cross connections).
All my work has been done using your commit
AS data flowas starting point.IOB COB graphworked perfectly without any conflicts...composeFeel free to comment ;-)