Adjust the date display in Statistics to use locale-based formatting …#4509
Open
Angus-repo wants to merge 1 commit intonightscout:devfrom
Open
Adjust the date display in Statistics to use locale-based formatting …#4509Angus-repo wants to merge 1 commit intonightscout:devfrom
Angus-repo wants to merge 1 commit intonightscout:devfrom
Conversation
…from the language resource files.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@MilosKozak
On the statistics page, the date format is currently determined by the phone’s time setting: using dd/MM for 24-hour format and MM/dd for 12-hour format. However, this does not always align with the actual date conventions used in different regions.
I have changed it so that MM/dd or dd/MM is determined based on the locale settings in the language (I10n) files.
Please review and let me know if this approach is acceptable.