Wear: Display New IOB in Wizard Result if IOB is used in calculations#4484
Open
olorinmaia wants to merge 2 commits intonightscout:devfrom
Open
Wear: Display New IOB in Wizard Result if IOB is used in calculations#4484olorinmaia wants to merge 2 commits intonightscout:devfrom
olorinmaia wants to merge 2 commits intonightscout:devfrom
Conversation
|
mcnelson
reviewed
Jan 16, 2026
| // New IOB = Total Insulin - Current IOB (because IOB is subtracted in wizard) | ||
| // Only calculate if IOB was actually used (totalIob is not NaN means it was included) | ||
| val newIob = if (!totalIob.isNaN()) { | ||
| totalInsulin - totalIob |
There was a problem hiding this comment.
Tiny suggestion-- to an outsider like me, this looks weird. This is addition because totalIob is negative, correct? Maybe comments could be more specific?
Suggested change
| totalInsulin - totalIob | |
| totalInsulin - totalIob // totalIob is negative so this is addition |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired from: #4462
We often look at calculations on Wear to see current IOB to make sure when adding the calculated bolus from Bolus Wizard that the new IOB doesn't exceed a certain amount.
I've made this improvement to the Wizard Result in Wear. It will only show if IOB is used in the calculations.
Some screenshots.
IOB "positive"
Current IOB: 0,58
Calculated Bolus: 0,44
New IOB after Bolus: 0,98
IOB "negative"
Current IOB: -0,13
Calculated Bolus: 0,90
New IOB after Bolus: 0,77
When IOB is not used in calculations:
