Skip to content

Fix BolusProgress on Watch#4480

Open
Philoul wants to merge 2 commits intonightscout:devfrom
Philoul:Todo/FixWearBolusProgress
Open

Fix BolusProgress on Watch#4480
Philoul wants to merge 2 commits intonightscout:devfrom
Philoul:Todo/FixWearBolusProgress

Conversation

@Philoul
Copy link
Contributor

@Philoul Philoul commented Jan 10, 2026

Add missing Total amount on Wear Watch BolusProgress Notification
BolusProgressDialog on phone unchanged
Dash driver use now EventOverviewBolusProgress for bolus delivery percentage
Fix #4472

Same bolus on the 2 screenshots below.
image

image

@olorinmaia could you check with Dash pump if now issue is fixed (I updated Dash Driver to use EventOverviewBolusProgress for bolus progress string (instead of creating the string locally into Dash Driver)

@sonarqubecloud
Copy link

@olorinmaia
Copy link
Contributor

olorinmaia commented Jan 11, 2026

I've tested this one day now with Dash and seem to be working fine and a good solution for my issue. I recommend patching this to master.

My only feedback is that I think this should be changed from:

    <!--    Events-->
    <string name="bolus_delivering">Delivering %1$.2fU</string>
    <string name="bolus_delivered_so_far">%1$.2fU / %2$.2fU delivered</string>
    <string name="bolus_delivered_successfully">Bolus %1$.2fU delivered successfully</string>

To:

     <!--    Events-->
    <string name="bolus_delivering">Delivering %1$.2f U</string>
    <string name="bolus_delivered_so_far">%1$.2f U / %2$.2f U delivered</string>
    <string name="bolus_delivered_successfully">Bolus %1$.2f U delivered successfully</string>

There could be reasons you don't want a space before "U" but at least we can fix this with translations in Norwegian to what we prefer. So not a big deal!

@Philoul
Copy link
Contributor Author

Philoul commented Jan 11, 2026

Here I removed the space to be sure the "U" of total amount will not be in a new row.

These spaces should normally be a "Non breaking space" &#160; everywhere in all strings we manage values with units...
I propose to update with the non breaking space here let's see later how we manage all the other strings in AAPS...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants