Skip to content

Tweak SepParserAvx512PackCmpOrMoveMaskTzcnt by moving MoveMask #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nietras merged 3 commits into from
Apr 19, 2025
Merged

Tweak SepParserAvx512PackCmpOrMoveMaskTzcnt by moving MoveMask #294

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f65ba4d
before setup
nietras Apr 19, 2025
9c46448
move MoveMask
nietras Apr 19, 2025
b05607f
revert struct
nietras Apr 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/Sep/Internals/SepParserAvx512PackCmpOrMoveMaskTzcnt.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,20 +108,20 @@ void Parse<TColInfo, TColInfoMethods>(SepReaderState s)
var permuteIndices = Vec.Create(0L, 2L, 4L, 6L, 1L, 3L, 5L, 7L);
var bytes = ISA.PermuteVar8x64(packed.AsInt64(), permuteIndices).AsByte();

var nlsEq = Vec.Equals(bytes, nls);
var crsEq = Vec.Equals(bytes, crs);
var qtsEq = Vec.Equals(bytes, qts);
var spsEq = Vec.Equals(bytes, sps);
var nlsEq = MoveMask(Vec.Equals(bytes, nls));
var crsEq = MoveMask(Vec.Equals(bytes, crs));
var qtsEq = MoveMask(Vec.Equals(bytes, qts));
var spsEq = MoveMask(Vec.Equals(bytes, sps));

var lineEndings = nlsEq | crsEq;
var lineEndingsSeparators = spsEq | lineEndings;
var specialChars = lineEndingsSeparators | qtsEq;

// Optimize for the case of no special character
var specialCharMask = MoveMask(specialChars);
var specialCharMask = specialChars;
if (specialCharMask != 0u)
{
var separatorsMask = MoveMask(spsEq);
var separatorsMask = spsEq;
// Optimize for case of only separators i.e. no endings or quotes.
// Add quote count to mask as hack to skip if quoting.
var testMask = specialCharMask + quoteCount;
Expand All @@ -132,7 +132,7 @@ void Parse<TColInfo, TColInfoMethods>(SepReaderState s)
}
else
{
var separatorLineEndingsMask = MoveMask(lineEndingsSeparators);
var separatorLineEndingsMask = lineEndingsSeparators;
if (separatorLineEndingsMask == testMask)
{
colInfosRefCurrent = ref ParseSeparatorsLineEndingsMasks<TColInfo, TColInfoMethods>(
Expand Down