Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for include and exclude patterns for project dependencies #113

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tombueng
Copy link

Implemented the following feature request: #36

tombueng added 2 commits May 12, 2021 17:04
Add support for include and exclude patterns for project dependencies nicoulaj#36
nicoulaj#36
Add support for include and exclude patterns for project dependencies nicoulaj#36
nicoulaj#36
@codecov
Copy link

codecov bot commented May 13, 2021

Codecov Report

Merging #113 (e457723) into master (607c016) will increase coverage by 0.25%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #113      +/-   ##
============================================
+ Coverage     78.36%   78.62%   +0.25%     
  Complexity      188      188              
============================================
  Files            27       27              
  Lines           661      669       +8     
  Branches         77       77              
============================================
+ Hits            518      526       +8     
  Misses          112      112              
  Partials         31       31              
Impacted Files Coverage Δ Complexity Δ
...laj/maven/plugins/checksum/mojo/ArtifactsMojo.java 83.87% <100.00%> (+2.38%) 18.00 <0.00> (ø)
.../maven/plugins/checksum/mojo/DependenciesMojo.java 77.27% <100.00%> (+5.05%) 11.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 607c016...e457723. Read the comment docs.

Copy link
Owner

@nicoulaj nicoulaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The naming of the new parameters is a bit inconsistent with the existing one: includeClassifiers. Would you mind renaming to includeGroupIds / etc ?

@tombueng
Copy link
Author

tombueng commented May 14, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants