Skip to content

Commit

Permalink
Remove apparently harmful validation of smart structure version
Browse files Browse the repository at this point in the history
Closes baruch#55
  • Loading branch information
baruch committed Jul 7, 2017
1 parent cd596a1 commit d3433ce
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions libscsicmd/src/ata.c
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,10 @@ int ata_parse_ata_smart_read_data(const unsigned char *buf, ata_smart_attr_t *at
if (!ata_check_ata_smart_read_data_checksum(buf))
return -1;

/* // Some disks do not return this expected value (Ticket #55)
if (ata_get_ata_smart_read_data_version(buf) != 0x0010)
return -1;
*/

int i, j;

Expand Down Expand Up @@ -117,8 +119,10 @@ int ata_parse_ata_smart_read_thresh(const unsigned char *buf, ata_smart_thresh_t
if (!ata_check_ata_smart_read_data_checksum(buf))
return -1;

/* // Some disks do not return this expected value (Ticket #55)
if (ata_get_ata_smart_read_data_version(buf) != 0x0010)
return -1;
*/

int i, j;

Expand Down

0 comments on commit d3433ce

Please sign in to comment.