Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't connect the Internet every time app starts or enters foreground #169

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

techee
Copy link
Contributor

@techee techee commented Apr 19, 2014

My app

https://itunes.apple.com/us/app/system-status-activity-monitor/id401457165?mt=8

shows the list of active network connections as one of its features. I've noticed that recently lots of connections started appearing after the app starts. It turns out iRate connects the internet every time the app is started or enters foreground.

After git blame, I got to this commit:

Updated to version 1.8.1
d3bc941

which contains quite a lot of changes but from the release notes, only this item seems to be relevant:

  • Calling openRatingsPageInAppStore will now look up appStoreID automatically if not already known

In my opinion the connectivity check shouldn't be there because it's checked in promptIfNetworkAvailable three lines after but only when needed. But take this as a patch from a guy who doesn't know what he's doing and maybe it breaks other things. Please check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant