Skip to content

Commit

Permalink
Fix dependency on coverage to be conditional to test extra (#606)
Browse files Browse the repository at this point in the history
Fix the Poetry dependency specification to include `coverage`
in the `test` extra.  Otherwise, `optional = true` is ignored
and an unconditional dependency is created.  Furthermore, using
`optional` without an `extra` is considered incorrect and may cause
Poetry to error out in the future, cf.:
python-poetry/poetry#2357
  • Loading branch information
mgorny authored Jan 2, 2024
1 parent 6ae1554 commit 78a1312
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ check-manifest = {version = "^0.45", optional = true}

[tool.poetry.extras]
test = ["pytest", "pytest-cov", "tox", "factory-boy", "flake8",
"check-manifest"]
"check-manifest", "coverage"]
yaml-plugin = ["ruamel.yaml"]
art-plugin = ["Pillow", "pylast", "requests"]

Expand Down

0 comments on commit 78a1312

Please sign in to comment.