Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CLAY_LOCAL_ID[I] #27

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Add CLAY_LOCAL_ID[I] #27

merged 3 commits into from
Sep 25, 2024

Conversation

bullno1
Copy link
Contributor

@bullno1 bullno1 commented Sep 24, 2024 •
edited
Loading

This uses the parent's id as seed for the id hash.

Motivation: #26

@bullno1
Add CLAY_LOCAL_ID[I]
e52756e 
This uses the parent's id as seed for the id hash.
nicbarker
nicbarker reviewed Sep 25, 2024
View reviewed changes
clay.h Outdated Show resolved Hide resolved
nicbarker
nicbarker reviewed Sep 25, 2024
View reviewed changes
clay.h Outdated Show resolved Hide resolved
nicbarker
nicbarker reviewed Sep 25, 2024
View reviewed changes
clay.h Outdated Show resolved Hide resolved
@nicbarker
Copy link
Owner

I've renamed LOCAL_ID to ID_LOCAL just for more consistent and easier discoverability via intellisense (i.e. if someone starts typing CLAY_ID they will see these options available) - apologies if this breaks something in your codebase!

nicbarker
nicbarker approved these changes Sep 25, 2024
View reviewed changes
Copy link
Owner

@nicbarker nicbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great job and thanks!

@nicbarker nicbarker merged commit 10cc866 into nicbarker:main Sep 25, 2024
@nicbarker nicbarker mentioned this pull request Sep 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicbarker nicbarker nicbarker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bullno1 @nicbarker