Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoided using batch_size to initialize layers to reconstruct images #430

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bolianchen
Copy link

Dear monodepth2 authors,

I noticed batch_size is required by the constructors of BackprojectDepth and Project3D. I removed this explicit dependency because it is likely to complicate further designs based on the repository and not beneficial in any perspectives. I also avoided wrapping self.id_coords with nn.Parameter although the change only saves ignorable GPU memory.

Best Regards,
Bolian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant