New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exempt groupableParentColumnId from i18n rule #159

Merged

jattasNI merged 2 commits into ni:main from m-akinc:groupableParentColumnId

Oct 18, 2024

Contributor

m-akinc commented Oct 18, 2024

The groupableParentColumnId attribute of the sl-table does not require translation, so add it to the exemptions.

m-akinc added 2 commits

October 18, 2024 16:51


          Exempt groupableParentColumnId from i18n rule

12a5838


          Change files

313e0ec

m-akinc requested review from jattasNI, mure, rajsite and TrevorKarjanis as code owners

October 18, 2024 21:52

jattasNI approved these changes

View reviewed changes

jattasNI merged commit ef3faf9 into ni:main

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jattasNI jattasNI approved these changes

mure Awaiting requested review from mure mure is a code owner

rajsite Awaiting requested review from rajsite rajsite is a code owner

TrevorKarjanis Awaiting requested review from TrevorKarjanis TrevorKarjanis is a code owner

Labels

None yet