Update node-version in build.yml from 20 to 22 #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jattasNI
requested review from
mure,
rajsite and
TrevorKarjanis
as code owners
1 task
rajsite
pushed a commit
to ni/nimble
that referenced
this pull request
Aug 29, 2024
# Pull Request ## 🤨 Rationale We were on Node 20 which is still LTS but 22 is now current and will become LTS. [Skyline is switching to 22](https://dev.azure.com/ni/DevCentral/_git/Skyline/pullrequest/786732) and [javascript-styleguide is too](ni/javascript-styleguide#154) so it makes sense to align with what will be on dev machines. ## 👩💻 Implementation Update GitHub Actions workflow and CONTRIBUTING.md ## 🧪 Testing <!--- Detail the testing done to ensure this submission meets requirements. Include automated/manual test additions or modifications, testing done on a local build, private CI run results, and additional testing not covered by automatic pull request validation. If any functionality is not covered by automated testing, provide justification. --> ## ✅ Checklist <!--- Review the list and put an x in the boxes that apply or ~~strike through~~ around items that don't (along with an explanation). --> - [x] I have updated the project documentation to reflect my changes or determined no changes are needed.
rajsite
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am upgrading Node across projects that our team contributes to. We want the versions to be aligned so that developers can have consistent behaviors across pipelines and their development machines.
See also:
ni/nimble#2364
https://dev.azure.com/ni/DevCentral/_git/Skyline/pullrequest/786732