-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Angular 17 #145
Merged
Merged
Update to Angular 17 #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-akinc
requested review from
jattasNI,
mure,
rajsite and
TrevorKarjanis
as code owners
May 17, 2024 21:04
rajsite
reviewed
May 17, 2024
change/@ni-eslint-config-angular-9ad7619f-6545-4755-83fa-124156f09929.json
Show resolved
Hide resolved
rajsite
reviewed
Jun 6, 2024
change/@ni-eslint-config-angular-9ad7619f-6545-4755-83fa-124156f09929.json
Show resolved
Hide resolved
rajsite
approved these changes
Jun 6, 2024
TrevorKarjanis
approved these changes
Jun 6, 2024
jattasNI
approved these changes
Jun 7, 2024
change/@ni-eslint-config-angular-9ad7619f-6545-4755-83fa-124156f09929.json
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated dependency on
@angular/core
to17.3.12
(latest <18) and@angular-eslint
packages to17.5.2
(latest <18)Testing
npm run print-evaluated-rules:diff
and ensured no changes.npm run print-evaluated-rules
to do an audit, which turned upno warnings or diverged rules.
npm run print-available-rules
and found that there were thefollowing new, unset rules available in the updated version of
https://github.com/angular-eslint:
@angular-eslint/consistent-component-styles
@angular-eslint/no-async-lifecycle-method
@angular-eslint/no-duplicates-in-metadata-arrays
@angular-eslint/prefer-standalone
@angular-eslint/template/prefer-control-flow