Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Angular 17 #145

Merged
merged 8 commits into from
Jul 18, 2024
Merged

Update to Angular 17 #145

merged 8 commits into from
Jul 18, 2024

Conversation

m-akinc
Copy link
Contributor

@m-akinc m-akinc commented May 17, 2024

Updated dependency on @angular/core to 17.3.12 (latest <18) and
@angular-eslint packages to 17.5.2 (latest <18)

Testing

  • I ran npm run print-evaluated-rules:diff and ensured no changes.
  • I ran npm run print-evaluated-rules to do an audit, which turned up
    no warnings or diverged rules.
  • I ran npm run print-available-rules and found that there were the
    following new, unset rules available in the updated version of
    https://github.com/angular-eslint:
    • @angular-eslint/consistent-component-styles
    • @angular-eslint/no-async-lifecycle-method
    • @angular-eslint/no-duplicates-in-metadata-arrays
    • @angular-eslint/prefer-standalone
    • @angular-eslint/template/prefer-control-flow

@rajsite rajsite marked this pull request as draft May 17, 2024 21:09
@m-akinc m-akinc marked this pull request as ready for review June 5, 2024 20:21
@m-akinc m-akinc requested a review from rajsite June 5, 2024 20:24
@rajsite rajsite merged commit b429463 into ni:main Jul 18, 2024
1 check passed
@m-akinc m-akinc deleted the angular17 branch October 18, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants