Merge branch 'angular17' of https://github.com/m-akinc/javascript-sty…

…leguide into angular17
ni · Jun 5, 2024 · bfa0289 · bfa0289
2 parents 8d412fb + 2330a1f
commit bfa0289
Show file tree

Hide file tree

Showing 5 changed files with 101 additions and 17 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/eslint-config-angular/CHANGELOG.json b/packages/eslint-config-angular/CHANGELOG.json
@@ -1,6 +1,36 @@
 {
   "name": "@ni/eslint-config-angular",
   "entries": [
+    {
+      "date": "Mon, 20 May 2024 14:25:28 GMT",
+      "version": "7.0.6",
+      "tag": "@ni/eslint-config-angular_v7.0.6",
+      "comments": {
+        "patch": [
+          {
+            "author": "[email protected]",
+            "package": "@ni/eslint-config-angular",
+            "commit": "44e51c0972fabd23f74b5ee78ff3005c0412bf36",
+            "comment": "Add more nimble i18n attr exceptions"
+          }
+        ]
+      }
+    },
+    {
+      "date": "Fri, 17 May 2024 21:03:50 GMT",
+      "version": "7.0.5",
+      "tag": "@ni/eslint-config-angular_v7.0.5",
+      "comments": {
+        "patch": [
+          {
+            "author": "[email protected]",
+            "package": "@ni/eslint-config-angular",
+            "commit": "3dba5ca7d817ec9a9ae50ea412dc73fec110903d",
+            "comment": "Add another SystemLink attribute for template/i18n"
+          }
+        ]
+      }
+    },
     {
       "date": "Fri, 17 May 2024 16:23:37 GMT",
       "version": "7.0.4",

diff --git a/packages/eslint-config-angular/CHANGELOG.md b/packages/eslint-config-angular/CHANGELOG.md
@@ -1,9 +1,25 @@
 # Change Log - @ni/eslint-config-angular
 
-This log was last generated on Fri, 17 May 2024 16:23:37 GMT and should not be manually modified.
+This log was last generated on Mon, 20 May 2024 14:25:28 GMT and should not be manually modified.
 
 <!-- Start content -->
 
+## 7.0.6
+
+Mon, 20 May 2024 14:25:28 GMT
+
+### Patches
+
+- Add more nimble i18n attr exceptions ([email protected])
+
+## 7.0.5
+
+Fri, 17 May 2024 21:03:50 GMT
+
+### Patches
+
+- Add another SystemLink attribute for template/i18n ([email protected])
+
 ## 7.0.4
 
 Fri, 17 May 2024 16:23:37 GMT

diff --git a/packages/eslint-config-angular/package.json b/packages/eslint-config-angular/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@ni/eslint-config-angular",
-  "version": "7.0.4",
+  "version": "7.0.6",
   "description": "NI's Angular ESLint Shareable Config",
   "main": "index.js",
   "scripts": {

diff --git a/packages/eslint-config-angular/template/options.js b/packages/eslint-config-angular/template/options.js
@@ -11,29 +11,70 @@
 // which can be used to scope attribute ignores to specific
 // elements.
 const ignoreAttributeSets = {
+    web: [
+        'accept',
+        'aria-describedby',
+        'aria-labelledby',
+        'aria-live',
+        'rel',
+        'sizes',
+        // Not possible for Angular i18n to handle meta tags yet
+        // https://github.com/angular/angular-cli/issues/8947
+        'meta[content]'
+    ],
     nimble: [
-        'action-menu-slot',
-        'activeid',
+        // shared
         'appearance',
         'appearance-variant',
+        'orientation',
+        'severity',
+        'slot',
+
+        // combobox
         'autocomplete',
+
+        // drawer
+        'location',
+
+        // rich text
+        'nimble-mapping-user[display-name]',
+        'pattern',
+
+        // select
+        'filter-mode',
+
+        // table
+        'action-menu-slot',
         'column-id',
         'field-name',
-        'filter-mode',
         'format',
+        'href-field-name',
         'icon',
         'id-field-name',
         'key',
         'key-type',
-        'nimbleRouterLink',
-        'orientation',
-        'queryParamsHandling',
-        'resize',
+        'label-field-name',
+        'parent-id-field-name',
         'selection-mode',
-        'severity',
-        'slot',
         'sort-direction',
-        'theme'
+        'width-mode',
+
+        // tabs
+        'activeid',
+
+        // text area
+        'resize',
+
+        // theme provider
+        'theme',
+
+        // tooltips
+        'anchor',
+
+        // angular-specific
+        'nimbleRouterLink',
+        'queryParamsHandling'
+
     ],
     systemlink: [
         // sl-workspace-selector
@@ -50,6 +91,7 @@ const ignoreAttributeSets = {
         'labelFieldName',
         'selectionMode',
         'slTableColumnId',
+        'widthMode',
 
         // sl-grid
         'columnSizeMode',
@@ -64,10 +106,6 @@ const ignoreAttributeSets = {
 
         // sl-query-builder
         'dropdownWidth',
-
-        // native element attributes used by sl components
-        'accept',
-        'aria-live',
     ],
     jqx: [
         // smart-table