Update Android Manifest #146
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Source code require the android:exported="true" to run on Android 12, kindly update, thanks
|
@ssohaib I've run your PR on Android 12 and it crashes with I think we have to keep |
|
Brother can you plz find a way to make it work with Android 12, I am not
very good at development.
…On Sun, Aug 28, 2022, 8:32 PM Nguyen Hoang Lam ***@***.***> wrote:
@ssohaib <https://github.com/ssohaib> I've run your PR on Android 12 and
it crashes with java.lang.RuntimeException: Unable to get provider
androidx.core.content.FileProvider: java.lang.SecurityException: Provider
must not be exported. Have you tested it yet?
I think we have to keep android:exported="false" for Provider.
—
Reply to this email directly, view it on GitHub
<#146 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AATSUH56YZBNXUXHYQRHGPLV3OBBDANCNFSM572K7ALA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
I run it on android 12 emulator and it works fine. What's your issue with android 12? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Source code require the android:exported="true" to run on Android 12, kindly update, thanks