feat(signals): add withFeature#4739
Merged
markostanimirovic merged 8 commits intongrx:mainfrom Mar 31, 2025
Merged
Conversation
✅ Deploy Preview for ngrx-io ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
rainerhahnekamp
force-pushed
the
feat/signal/with-feature
branch
from
ac9ddff to
05ce600
Compare
Contributor
Author
|
@markostanimirovic, @timdeschryver. should be ready for review. following things have been changed compared to the initial commit:
|
rainerhahnekamp
force-pushed
the
feat/signal/with-feature
branch
from
d1ea666 to
d432c13
Compare
rainerhahnekamp
force-pushed
the
feat/signal/with-feature
branch
from
d432c13 to
bbcf19b
Compare
projects/ngrx.io/content/guide/signals/signal-store/custom-store-features.md
Outdated
Show resolved
Hide resolved
projects/ngrx.io/content/guide/signals/signal-store/custom-store-features.md
Outdated
Show resolved
Hide resolved
timdeschryver
approved these changes
Mar 30, 2025
`withFeature` adds the possibility to pass on signals, methods, or properties from a store to a custom feature. Closes ngrx#4678
Co-authored-by: Tim Deschryver <28659384+timdeschryver@users.noreply.github.com>
Co-authored-by: Tim Deschryver <28659384+timdeschryver@users.noreply.github.com>
…re-features.md Co-authored-by: Tim Deschryver <28659384+timdeschryver@users.noreply.github.com>
…re-features.md Co-authored-by: Tim Deschryver <28659384+timdeschryver@users.noreply.github.com>
Co-authored-by: Marko Stanimirović <markostanimirovic95@gmail.com>
rainerhahnekamp
force-pushed
the
feat/signal/with-feature
branch
from
100d1ea to
485d9fd
Compare
markostanimirovic
approved these changes
Mar 31, 2025
Contributor
|
Nice, I like it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
withFeatureadds the possibility to pass on signals, methods, or properties from a store to a custom feature.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Closes #4678
Does this PR introduce a breaking change?