feat(signals): infer and narrow EntityId type in withEntities#4737
Closed
Chiorufarewerin wants to merge 1 commit intongrx:mainfrom
Closed
feat(signals): infer and narrow EntityId type in withEntities#4737Chiorufarewerin wants to merge 1 commit intongrx:mainfrom
EntityId type in withEntities#4737Chiorufarewerin wants to merge 1 commit intongrx:mainfrom
Conversation
✅ Deploy Preview for ngrx-io canceled.Built without sensitive environment variables
|
Member
|
Thanks for working on this, @Chiorufarewerin! However, before opening the PR, the feature request needs to be accepted first. More info is available in our contribution guidelines. We'll consider the feature request #4570 and let you know if it will be accepted or not. Until then, I'm going to close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Closes #4570
Does this PR introduce a breaking change?
Additional info
I have already submitted this PR, but after further consideration, I came up with an alternative solution. I prefer this new approach because
EntityIdis more narrowly typed and properly inferred. However, it introduces breaking changes...