Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update split design with some clearer details #2836

Merged
merged 3 commits into from
Nov 27, 2024

Conversation

sjberman
Copy link
Contributor

Cleared up the approach to configuring the nginx deployments when the control plane deploys them.

Cleared up the approach to configuring the nginx deployments when the control plane deploys them.
@sjberman sjberman requested review from a team as code owners November 27, 2024 15:41
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 27, 2024
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.86%. Comparing base (dd3892a) to head (c8cf5ce).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2836   +/-   ##
=======================================
  Coverage   89.86%   89.86%           
=======================================
  Files         107      107           
  Lines       10997    10997           
  Branches       50       50           
=======================================
  Hits         9883     9883           
  Misses       1054     1054           
  Partials       60       60           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjberman sjberman enabled auto-merge (squash) November 27, 2024 21:35
@sjberman sjberman merged commit fa96274 into nginxinc:main Nov 27, 2024
40 checks passed
@sjberman sjberman deleted the design/cp-dp-split branch November 27, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants