Add more unit tests for GRPCRoute #2835
Open
+542
−170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: The change_processor tests were missing GRPCRoute cases. Solution: Add these test cases to improve coverage of GRPCRoutes.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2835 +/- ##
=======================================
Coverage 89.86% 89.86%
=======================================
Files 107 107
Lines 10997 10997
Branches 50 50
=======================================
Hits 9883 9883
Misses 1054 1054
Partials 60 60 ☔ View full report in Codecov by Sentry. |
salonichf5
approved these changes
Dec 2, 2024
| expRouteGR1, expRouteGR2 *graph.L7Route | ||
| expRouteTR1, expRouteTR2 *graph.L4Route | ||
| gatewayAPICRD, gatewayAPICRDUpdated *metav1.PartialObjectMetadata | ||
| routeKey1, routeKey2, grpcRouteKey1, grpcRouteKey2 graph.RouteKey |
There was a problem hiding this comment.
nit: we should rename these keys to httpRouteKey1, just to be consistent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: The change_processor tests were missing GRPCRoute cases.
Solution: Add these test cases to improve coverage of GRPCRoutes.
Closes #2352
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.