-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update data/control plane split design #2729
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
Improvements or additions to documentation
label
Oct 28, 2024
kate-osborn
requested changes
Oct 29, 2024
sjberman
force-pushed
the
design/cp-dp-split
branch
from
November 11, 2024 16:22
f78ef82
to
c32889e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2729 +/- ##
=======================================
Coverage 89.86% 89.86%
=======================================
Files 107 107
Lines 10997 10997
Branches 50 50
=======================================
Hits 9883 9883
Misses 1054 1054
Partials 60 60 ☔ View full report in Codecov by Sentry. |
salonichf5
reviewed
Nov 18, 2024
salonichf5
reviewed
Nov 18, 2024
salonichf5
reviewed
Nov 18, 2024
sjberman
force-pushed
the
design/cp-dp-split
branch
3 times, most recently
from
November 25, 2024 15:59
039e08a
to
245f57f
Compare
sjberman
commented
Nov 25, 2024
kate-osborn
reviewed
Nov 25, 2024
With the upcoming agent v3 release, the design for our control plane and data plane separation needs an update. Much of this is based off of discoveries from a recent PoC, as well as predicted design and implementation details that may be necessary. Added a new proposal that supersedes the old design.
sjberman
force-pushed
the
design/cp-dp-split
branch
from
November 25, 2024 22:45
672b8fb
to
9b7788a
Compare
salonichf5
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me !
kate-osborn
approved these changes
Nov 26, 2024
mpstefan
reviewed
Nov 26, 2024
mpstefan
reviewed
Nov 26, 2024
mpstefan
reviewed
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the upcoming agent v3 release, the design for our control plane and data plane separation needs an update. Much of this is based off of discoveries from a recent PoC, as well as predicted design and implementation details that may be necessary. Added a new proposal that supersedes the old design.
Closes #2655