Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependabot, add more tools to renovate #2448

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

lucacome
Copy link
Member

Proposed changes

Problem: dependabot is not very configurable and can't keep track of all of our dependencies. It also has been missing some updates lately.

Solution: Remove dependabot and use renovate. This also allows us to remove some dependencies from tools.go and control them directly in the Makefile.

Closes #1665
Closes #2424

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@lucacome lucacome requested a review from a team as a code owner August 22, 2024 02:10
@github-actions github-actions bot added dependencies Pull requests that update a dependency file chore Pull requests for routine tasks labels Aug 22, 2024
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.84%. Comparing base (6e86f7e) to head (4690860).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2448   +/-   ##
=======================================
  Coverage   88.84%   88.84%           
=======================================
  Files         100      100           
  Lines        7527     7527           
  Branches       50       50           
=======================================
  Hits         6687     6687           
  Misses        784      784           
  Partials       56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sjberman sjberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome

@sjberman
Copy link
Contributor

Do we still need .nvmrc? Or can we specify the literal version in the workflows?

@lucacome
Copy link
Member Author

It might be useful if somebody is running node locally and not in a container, not sure how common that is tho

Problem: dependabot is not very configurable and can't keep track of all
of our dependencies. It also has been missing some updates lately.

Solution: Remove dependabot and use renovate. This also allows us to
remove some dependencies from tools.go and control them directly in the
Makefile.
@lucacome lucacome enabled auto-merge (squash) August 22, 2024 19:50
@lucacome lucacome merged commit 2db2ef7 into nginxinc:main Aug 22, 2024
33 of 37 checks passed
@lucacome lucacome deleted the chore/renovate branch August 22, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks dependencies Pull requests that update a dependency file
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Investigate Renovate Keep OTel collector version updated in product telemetry functional test
4 participants