chore: Automate functional tests in the pipeline #1631
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salonichf5
changed the title
salonichf5
commented
Feb 29, 2024
| Expect(resourceManager.DeleteFromFiles(files, ns.Name)).To(Succeed()) | ||
| Expect(resourceManager.Delete([]client.Object{ns})).To(Succeed()) | ||
| outFile.Close() | ||
| }) | ||
|
|
||
| It("sends traffic", func() { |
There was a problem hiding this comment.
need to document test results in the output file.
salonichf5
force-pushed
the
functional-test
branch
from
43b718a
to
4a9f922
Compare
salonichf5
changed the title
github-actions
bot
added
the
documentation
updates: - [github.com/golangci/golangci-lint: v1.56.1 → v1.56.2](golangci/golangci-lint@v1.56.1...v1.56.2) - [github.com/adrienverge/yamllint.git: v1.34.0 → v1.35.1](https://github.com/adrienverge/yamllint.git/compare/v1.34.0...v1.35.1) --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
salonichf5
force-pushed
the
functional-test
branch
from
538016b
to
b304df3
Compare
sjberman
reviewed
Feb 29, 2024
tests/suite/sample_test.go
Outdated
| @@ -14,7 +16,8 @@ import ( | |||
| "github.com/nginxinc/nginx-gateway-fabric/tests/framework" | |||
| ) | |||
|
|
|||
| var _ = Describe("Basic test example", func() { | |||
| var _ = Describe("Basic test example", Ordered, Label("functional"), func() { | |||
There was a problem hiding this comment.
This doesn't need to be Ordered, so you can leave the BeforeEach and AfterEach in place.
salonichf5
force-pushed
the
functional-test
branch
from
3c8e118
to
cf1bbd2
Compare
salonichf5
force-pushed
the
functional-test
branch
from
6035b32
to
5e785d8
Compare
|
Closing this pull request and opening a PR against main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:
Problem: As a user, I want to automate functional tests in the pipeline
Solution: To run functional tests in the pipeline, we introduce a new github workflow that sets up the environment to run tests, and upload results
Testing: Manual testing by pushing to the branch
Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.
Closes #1562
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.