Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep OTel collector version updated in product telemetry functional test #1665

Closed
pleshakov opened this issue Mar 11, 2024 · 4 comments · Fixed by #2448
Closed

Keep OTel collector version updated in product telemetry functional test #1665

pleshakov opened this issue Mar 11, 2024 · 4 comments · Fixed by #2448
Labels
backlog Currently unprioritized work. May change with user feedback or as the product progresses.

Comments

@pleshakov
Copy link
Contributor

#1659 added a functional test that install OTel collector in a cluster using helm.
For predictability, the version of the chart is kept static in a go file:

const (
	. . .
	collectorChartVersion = "0.73.1"
)

Find a automated way to keep the version updated here similar to dependabot.

Copy link
Contributor

This issue is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale Pull requests/issues with no activity label Mar 26, 2024
Copy link
Contributor

This issue was closed because it has been stalled for 14 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 10, 2024
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Apr 10, 2024
@sjberman sjberman removed the stale Pull requests/issues with no activity label Apr 10, 2024
@sjberman sjberman moved this from ✅ Done to 🆕 New in NGINX Gateway Fabric Apr 10, 2024
@sjberman sjberman added the backlog Currently unprioritized work. May change with user feedback or as the product progresses. label Apr 10, 2024
@sjberman sjberman reopened this Apr 11, 2024
@bjee19
Copy link
Contributor

bjee19 commented Apr 17, 2024

#1832 Also adds a constant version which should be fixed to update automatically.

const (
    debugImage = "busybox:1.28"
)

@bjee19
Copy link
Contributor

bjee19 commented Apr 25, 2024

Update: #1832 no longer adds a constant version and thus does not need to be taken into consideration.

@lucacome lucacome moved this from 🆕 New to 👀 In Review in NGINX Gateway Fabric Aug 22, 2024
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in NGINX Gateway Fabric Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Currently unprioritized work. May change with user feedback or as the product progresses.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants