-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow configuration of NGINX Plus API access #3066
Conversation
✅ Deploy Preview will be available once build job completes!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3066 +/- ##
==========================================
+ Coverage 90.00% 90.06% +0.05%
==========================================
Files 111 112 +1
Lines 11501 11570 +69
Branches 50 50
==========================================
+ Hits 10351 10420 +69
Misses 1089 1089
Partials 61 61 ☔ View full report in Codecov by Sentry. |
The |
Realized I hadn't added any checks to NOT generate the nginx plus template code when running on oss. Added those checks by not populating the NginxPlus Configuration resource if we are running not in plus. Manually verified that the nginx plus template code is not present when running on oss, and still is present when running on plus. Cool that this got caught in our automated Helm chart tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
Add back removed comments Adjust comment
69292b8
to
b538622
Compare
Allow configuration of NGINX Plus API access.
Problem: We want the ability to configure access to the NGINX Plus dashboard.
Solution: Add a field
AllowedAddresses
in the NginxProxy API to allow the user to configure access to the NGINX Plus dashboard.Testing: Unit tests. Manually configured an NginxProxy resource, set up a Kind cluster with a Nodeport following our Get started guide, and confirmed that I could access the dashboard without needing to port-forward. Verified nginx plus template code is present when running on nginx plus and not present when running on nginx oss.
Closes #2716
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.