Skip to content

Conversation

@kornkv
Copy link
Contributor

@kornkv kornkv commented Dec 8, 2025

draft of FASTQ_REMOVE_ADAPTERS_AND_MERGE subworkflow with tests

mirpedrol and others added 25 commits December 8, 2025 17:00
* add ontologies to tcoffee regressive

* add ontologies to upp align
* Add module pbmarkdup

* Fix linting

* Update path to test data

* Update with code review (--dup-file, log, check file name collisions)

* Fix linting

* Update path to test data

* Update modules/nf-core/pbmarkdup/meta.yml

* Fix linting
* Enable complex contrast strings

* Update docker image

* Add test case with limma contrast string

* Format changes and add test with shrinkage
* Add deepvariant optional html

* update snapshot

* Update modules/nf-core/deepvariant/rundeepvariant/main.nf

Co-authored-by: Ramprasad Neethiraj <[email protected]>

* trigger html generation

* revert config change

---------

Co-authored-by: Ramprasad Neethiraj <[email protected]>
HISAT2 uses .ht2l extension instead of .ht2 for large genomes.
Updated index detection to match both extensions.

Related to nf-core/rnaseq#1643

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude <[email protected]>
…erministic (#9489)

* Sort file listing so "first" file is deterministic

* Declare closure parameter per strict syntax

Co-authored-by: Matthias Hörtenhuber <[email protected]>

---------

Co-authored-by: Matthias Hörtenhuber <[email protected]>
Co-authored-by: mashehu <[email protected]>
* sambamba add region bed input

* fix linting

* fix linting

* Apply suggestions from code review

Co-authored-by: Felix Lenner <[email protected]>

---------

Co-authored-by: Felix Lenner <[email protected]>
* fix fasta_index_methylseq and fastq_align_dedup workflows for clarity and consistency

- Updated variable names in fasta_index_methylseq to use 'channel' instead of 'Channel' for consistency.
- Renamed UNTAR to UNTAR_BISMARK and UNTAR_BWAMETH for clarity in fasta_index_methylseq.
- Enhanced comments and descriptions in meta.yml files for better understanding of input and output structures.
- Adjusted test cases in fastq_align_dedup workflows to reflect changes in input structure from single-end to paired-end.
- Updated version numbers in test snapshots to reflect recent changes.

* fix: pre-commit lint fixes
* Update glimpse

* Update chunk

* Update concordance

* Revert changes

* Fix glimpse test

* Fix glimpse

* Fix glimpse2 tests

* Update sbwf

* Remove old snapshots

* Update glimpse

* Update modules/nf-core/glimpse2/concordance/tests/main.nf.test

Co-authored-by: Matthias Hörtenhuber <[email protected]>

* Update test

---------

Co-authored-by: LouisLeNezet <[email protected]>
Co-authored-by: Matthias Hörtenhuber <[email protected]>
)

* fix order

* add container section

* simplify schema

* require https for singluarity
* update and add topics

* add new topics structure

* add stub test and capture version in snapshot

* update to 9.14.0

* fix singularity be setting cache_dir

* fix stub

---------

Co-authored-by: Matthias Hörtenhuber <[email protected]>
Co-authored-by: mashehu <[email protected]>
* fix stub version

* stray module
- Add missing gene_id_col parameter definition (defaults to 'gene_id')
- Include gene IDs as first column in all results tables using configurable column name
- Only write output files when there are significant results to avoid empty files
- Mark all results TSV outputs as optional since they're conditionally created
- Update test to use buffering results instead of empty mRNA_abundance results
- Update test snapshots with new file formats including gene_id column

This ensures anota2seq results are consistent with other modules and include
gene identifiers for downstream analysis, while gracefully handling cases
where no genes pass significance thresholds.

Co-authored-by: Sebastian Uhrig <[email protected]>
#9516)

fix(decoupler): reorder imports and ensure environment variables are set before importing modules
Add strdrop build
…9201)

* 🔧 update image and bioconda container to latest version

* ✅ update test snapshots

* 🐛 fix display of version of vuegen

- had no command line interface option to display version, see
Multiomics-Analytics-Group/vuegen#167

* 🎨 display versions.yml content in snapshots

* 🔧 add Dockerfile to install lastet PyPI vuegen version

- does not pass hadolint(er) as of now

* 🚧 add wave containers

* 🔥 remove README again

* 🔥 remove Dockerfile again

* 🚧 try to follow Mahesh's advice

* 🐛 add explicit cache directory

* 🔧 bump to Python 3.12 and remove channel prefix

* 🔧 specify singularity image with https

... as specified in the docs:
https://nf-co.re/docs/tutorials/nf-core_components/using_seqera_containers

* 🚧 set user specified R libarary folder

* ⏪ make docker and conda work again (using nf-core 3.5.1)

* 🔧 switch again to custom docker image instead of wave

- wave leads to too many custom installation issues

* 🐛 try to add font package

* 🔥 remove code moved to image

- singularity runs in devcontainer

* ⏪ add back conda quarto flag

* 🎨 remove trailing whitespace

* 🎨 format again

* 🎨 hopefully the last trailing whitespace

* 📝 document the build process and why the container is needed

* Update image with nf-core one

Co-authored-by: Matthias Hörtenhuber <[email protected]>

* Update container name

Co-authored-by: Matthias Hörtenhuber <[email protected]>

* Apply suggestion from @mashehu

* Apply suggestion from @mashehu

---------

Co-authored-by: Famke Bäuerle <[email protected]>
Co-authored-by: Matthias Hörtenhuber <[email protected]>
* Update semibin2 module

* Update snapshot

* Remove unneeded snapshot section

---------

Co-authored-by: Matthias Hörtenhuber <[email protected]>
@vagkaratzas vagkaratzas requested review from a team and maxulysse as code owners December 8, 2025 17:00
@vagkaratzas vagkaratzas marked this pull request as draft December 8, 2025 17:06
@vagkaratzas vagkaratzas marked this pull request as ready for review December 9, 2025 14:29
@vagkaratzas vagkaratzas requested a review from jfy133 December 9, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.