New module: whatshap/phase #9431
Merged
+343
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
famosab
reviewed
Nov 24, 2025
|
|
||
| then { | ||
| assertAll( | ||
| { assert process.success } |
Contributor
There was a problem hiding this comment.
Can you also add a snapshot please?
Contributor
Author
There was a problem hiding this comment.
Yes, the snapshot is added now. Here, I don't add the vcf as it will output the local dir to the snapshot file.
Contributor
There was a problem hiding this comment.
Suggested change
| { assert process.success } | |
| { assert process.success } | |
| { assert snapshot(process.out).match() } |
This should work for the stub test :)
Contributor
Author
|
@famosab Could you clean up the additional ci/cd for this PR? |
Contributor
Author
|
@famosab Fixed all the issues, please review it again. |
famosab
reviewed
Dec 8, 2025
Comment on lines
16
to
17
| tuple val(meta), path("*.phased.vcf.gz"), emit: vcf | ||
| tuple val(meta), path("*.phased.vcf.gz.tbi"), emit: tbi |
Contributor
There was a problem hiding this comment.
We ususally try to not enforce file names :) see
modules/modules/nf-core/wittyer/main.nf
Line 31 in e7cb586
maybe you can do it similarly here :)
Contributor
Author
There was a problem hiding this comment.
Thank you for pointing this. It's been fixed now.
famosab
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Closes #9427
versions.ymlfile.labelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda