-
Notifications
You must be signed in to change notification settings - Fork 33
Fix taxonomy merging scripts and ouput #435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Warning Newer version of the nf-core template is available. Your pipeline is using an old version of the nf-core template: 3.1.0. For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation. |
|
|
@nf-core-bot fix linting |
jfy133
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've not checked the python code, but looks OK except for missing CHANGELOG
jasmezz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also did not scrutinize the updated python script here.
|
@jfy133 and @jasmezz As requested, a summary of changes of this script:
|
jasmezz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, you have a go from me :) Only thing, I didn't follow the exact row manipulation for the hamronization parsing. It's fine by me, I'll just check if the resulting output file looks correct.
Co-authored-by: Jasmin Frangenberg <[email protected]>
Co-authored-by: Jasmin Frangenberg <[email protected]>
Co-authored-by: Jasmin Frangenberg <[email protected]>
Co-authored-by: Jasmin Frangenberg <[email protected]>
This PR updates pandas dependencies issues and fixes the taxonomy merging issues that were reported by users. Especially the ARG hamronization merging step were many taxonomy lineages were 'incorrectly' missing!
PR checklist
nf-core lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).