Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nextstrain_profiles/nextstrain-country #1120

Closed
2 tasks
joverlee521 opened this issue Jun 26, 2024 · 5 comments · Fixed by #1123
Closed
2 tasks

Remove nextstrain_profiles/nextstrain-country #1120

joverlee521 opened this issue Jun 26, 2024 · 5 comments · Fixed by #1123
Assignees

Comments

@joverlee521
Copy link
Contributor

joverlee521 commented Jun 26, 2024

From discussion below, we've decided to just remove rebuild_country.yml + nextstrain_profiles/nextstrain-country since they are not actively being used


Context

I originally flagged this in #1119 (comment):

I don't think this profile ever worked as intended, since the build names have three parts delimited by underscores (e.g. nextstrain_country_1m), while our auspice config rule only expects two parts:

if "_" in build_name:
build_region, build_timespan = build_name.split("_")

Possible solutions

Easiest change would be to switch build names from nextstrain_country_1m to country_1m. However, this would change Auspice JSON file names which would change the build URLs on nextstrain.org

TODOs

@joverlee521
Copy link
Contributor Author

However, this would change Auspice JSON file names which would change the build URLs on nextstrain.org

I cannot find any builds in s3://nextstrain-data with the nextstrain_country_<time> name so maybe this is a non-issue?

@trvrb, could you comment on whether the proposed change would affect your work? I think you might be the only one who has used this profile?

@victorlin
Copy link
Member

If there's no evidence that rebuild_country.yml + nextstrain_profiles/nextstrain-country are actively used, I'd vote to remove them (as briefly mentioned in #1119 (comment))

@joverlee521
Copy link
Contributor Author

Asking for feedback on Slack

@trvrb
Copy link
Member

trvrb commented Jul 2, 2024

I haven't used this in a long while (I'm not even sure it was ever working correctly). I do think it's good functionality to be able to look at what's circulating in a particular country. This would be for one-off analyses that are not uploaded to data.nextstrain.org. It's generally not currently much of a priority for this to be working. I'd be okay with it being cut out if it's not working.

@joverlee521
Copy link
Contributor Author

Thanks for the feedback! I'll just remove rebuild_country.yml + nextstrain_profiles/nextstrain-country then.

@joverlee521 joverlee521 changed the title Fix nextstrain_profiles/nextstrain-country builds Remove nextstrain_profiles/nextstrain-country Jul 3, 2024
@joverlee521 joverlee521 self-assigned this Jul 3, 2024
joverlee521 added a commit that referenced this issue Jul 3, 2024
As discussed in #1120, this
profile does not work as expected and is not actively being used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants