Remove version columns #468
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we are creating a Nextclade version JSON for the Nextclade TSV, we can use it to fetch the cache version. If the Nextclade TSV sha256sum doesn't match the value in the version JSON, then we ignore the version JSON which results in the workflow ignoring the Nextclade cache.
We now check the Nextclade versions using the separate version JSON, so we no longer need to track version per row. This is a breaking change for the cache, so will need to be run with the renew flag to manually force a full-rerun.
joverlee521
force-pushed
the
remove-version-columns
branch
from
1ebab5c to
3e86a9f
Compare
|
I plan on doing more thorough testing on this next week but wanted to get people's eyes on this to make sure we are okay with removing the extra Nextclade version columns. I don't think anyone is using the version columns for downstream work, but wanted to double check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Updates the cache version check to use the version JSON added in #467 and removes the version columns from the Nextclade TSV.
Removal of the version columns should be considered a breaking change for the Nextclade cache. Once merged, this will need to be run with the renew flags to manually force a full-rerun.
Checklist