You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When the user's metadata does not have the two columns referenced in that query (as happens when analyzing data from GISAID, for example), augur filter produces the following output:
WARNING: Column 'QC_rare_mutations' does not exist in the metadata file. Ignoring it.
ERROR: Query contains a column that does not exist in metadata.
Although that output comes across as an augur bug (that a warning is also an error), the proximal issue is that the workflow hardcodes parameters that the user cannot override without changing the workflow itself.
Proposed solution
I suggest moving the query string into the config files for the various workflows, specifically moving the hardcoded query into the top-level filter section of each config file (e.g., defaults/mpxv/config.yaml). Then users who want to analyze data without the fields referenced in that query can create their own config file.
The text was updated successfully, but these errors were encountered:
Description
The following hardcoded filter parameter appears at the start of the phylogenetic workflow:
mpox/phylogenetic/rules/prepare_sequences.smk
Line 85 in 2ce0d92
When the user's metadata does not have the two columns referenced in that query (as happens when analyzing data from GISAID, for example),
augur filter
produces the following output:Although that output comes across as an
augur
bug (that a warning is also an error), the proximal issue is that the workflow hardcodes parameters that the user cannot override without changing the workflow itself.Proposed solution
I suggest moving the query string into the config files for the various workflows, specifically moving the hardcoded query into the top-level
filter
section of each config file (e.g.,defaults/mpxv/config.yaml
). Then users who want to analyze data without the fields referenced in that query can create their own config file.The text was updated successfully, but these errors were encountered: