Update help about coloring types #224
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
genehack
approved these changes
Aug 20, 2024
- fix inline literal date example - add required leading blank line for bullet list - fix typo
Reordering the flow to define the color types and data requirements first then list out inference order.
genehack
approved these changes
Aug 20, 2024
joverlee521
approved these changes
Aug 20, 2024
There was a problem hiding this comment.
Thanks for these additions @emmahodcroft!
I added f5e5998 to fix some minor formatting issues and reordered things in 69620b8 to define the color types and data requirements first then list out inference order.
jameshadfield
approved these changes
Aug 20, 2024
|
|
||
| To use these categories the data should be in the format: | ||
|
|
||
| - "boolean" - values should all be within ``["false", "true", "1.0", "0.0", "1", "0", "yes", "no"]``; coloring will be binary |
There was a problem hiding this comment.
[not blocking, especially as this list already existed in the previous version of the docs]
Actual numbers/booleans (as opposed to just strings) will work in Auspice but they don't always make it through augur export v2 (and I don't think we've documented which do / don't). The auspice code is:
if (["true", "1", "yes"].includes(String(val).toLowerCase()))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preview
Description of proposed changes
Adding info about how to use different colouring types in the config file - what format data should be and how the colours/legend will look