feat: Make osx-arm64 version of conda-base #80
Conversation
| - macos-12 # x86_64 | ||
| - macos-14 # arm64 |
There was a problem hiding this comment.
Testing in nextstrain/cli#379. We could also test more directly by addressing this:
conda-base/.github/workflows/ci.yaml
Line 143 in 2704195
There was a problem hiding this comment.
If you know how please do!
There was a problem hiding this comment.
Continuing in #83. It's looking quite complicated so let's not let it block this PR and use other ways to test instead.
| - pulp <2.8 | ||
| - ruby | ||
| - seqkit | ||
| # TODO: We should avoid pinning too long, this pin was placed in 2023-12-21 |
There was a problem hiding this comment.
I understand where you're coming from here. Supporting Snakemake 8 will require coordination with existing pathogen repos (e.g. nextstrain/ncov#1114). I think it'd be better to surface as an issue in nextstrain/private, not a comment in this file.
There was a problem hiding this comment.
Why not both? It's not an XOR is it 😄
I feel we are too sticky with snakemake - all the code I maintain already works with v8, just some people don't seem to migrate. I remember last time it was quite an effort and I felt quite alone doing it as no one minds using outdated stuff.
And here again, you made that comment 7 months ago yet nothing happened since then 😛
There was a problem hiding this comment.
I think there's a misunderstanding here... I'm not against updating. Maybe I care a bit less because I don't use Snakemake in daily work, so I value your opinion as a more active user of it. My point is that simply adding a note as an unrelated TODO in this PR isn't going to get things moving.
I've created this issue which should be more visible. Feel free to edit: https://github.com/nextstrain/private/issues/120
|
Will take a few minutes for gzip arm64 to become available, rerun later then it should work Update: it works |
I will squash :) |
corneliusroemer
requested review from
jameshadfield,
huddlej,
genehack and
joverlee521
corneliusroemer
changed the title
Description of proposed changes
Build conda-base for osx-arm64 as well.
To make use of it within nextstrain cli, it seems we need to download micromamba arm64 rather than the x86_64 version - but the package can already be used via:
The platform arg is so that it should also work with an x86_64 micromamba installation.
Related issue(s)
Resolves nextstrain/private#77
Checklist
Checklist post merge