You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I don't think this is part of the scope of this PR, but it would seem cleaner to me for this clade-labeling/add-clades.py script to instead just create a node data JSON with h5_label_clade rather than messing with the metadata file.
@lmoncla and I just had some confusion from different rules (refine, traits) asking for the metadata TSV vs the metadata-with-clade TSV. Though the function metadata_by_wildcards mostly solves this issue.
The only reason I can see to not do this is if we use this data in the filtering step. But we don't.
Description
We should modify scripts/add-clades.py to create a node data JSON file as output and update the workflow to make the resulting output an input to the export rule instead of a step that modifies the metadata.
The text was updated successfully, but these errors were encountered:
Context
In conversation about #22, @trvrb noted:
@jameshadfield noted that:
Description
We should modify
scripts/add-clades.py
to create a node data JSON file as output and update the workflow to make the resulting output an input to theexport
rule instead of a step that modifies the metadata.The text was updated successfully, but these errors were encountered: