Update entropy types #1915
Open
Update entropy types #1915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for more specific type narrowing.
Improves readability.
Improves readability.
This allows some code editors to show the comment on hover. I also added two new types (Phase, Frame) to replace some comments.
For consistency.
These were not consistent in the same file. I've also opted to not use them in the tree component types.
The previous error message code indicated the possibility that this property is unset. Express that directly in the type annotation and simplify the error message code.
Checking against undefined is more direct.
nextstrain-bot
temporarily deployed
to
auspice-victorlin-updat-jrdeox
genehack
approved these changes
Nov 21, 2024
| end?: number | ||
| start?: number | ||
| segments?: JsonSegmentRange[] | ||
| strand?: Strand |
There was a problem hiding this comment.
making sure this needed to become optional to match some usage somewhere?
There was a problem hiding this comment.
In 2d3a331 the matched usage was Object.prototype.hasOwnProperty.call(annotation, "strand") which to me indicates that it is optional. It's hard to tell from other usage because the entire JsonAnnotation object is represented by json.meta.genome_annotations here:
auspice/src/actions/recomputeReduxState.js
Line 819 in a7578d2
auspice/src/actions/recomputeReduxState.js
Line 870 in a7578d2
@jameshadfield might have a better idea.
At first, I disabled @typescript-eslint/consistent-type-assertions for the type assertion in the original code, but that ended up polluting the _frame() function with details unrelated to the direct purpose of the function. Extracting the modulus operation into a separate function and adding the details there felt like a better scope.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Updates TypeScript usage to be consistent with #1864, etc.
I thought of these changes after adding 6215591.
Checklist
If making user-facing changes, add a message in CHANGELOG.md summarizing the changes in this PR(to be done by a Nextstrain team member) Create preview PRs on downstream repositories.