Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust placement of focus toggle #1875

Merged
merged 5 commits into from
Oct 23, 2024
Merged

Conversation

victorlin
Copy link
Member

@victorlin victorlin commented Oct 22, 2024

nextstrain.org preview

focus-toggle

Follow-up to #1373 prompted by Slack feedback

Checklist

This allows experimental and non-experimental toggles to appear visually
aligned.
Adjust the confidence interval toggle's margin for visual alignment.
@victorlin victorlin temporarily deployed to auspice-victorlin-focus-koraxw October 22, 2024 22:06 Inactive
This aligns better with "toggle: Make experimental icon float to the
left" (9463c3a).
@victorlin victorlin temporarily deployed to auspice-victorlin-focus-koraxw October 23, 2024 16:36 Inactive
Copy link
Contributor

@genehack genehack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assume you checked at different zoom levels and the hard-coded absolute position stuff works at all scales?

@victorlin
Copy link
Member Author

Yes, I played around with zoom levels and viewport sizes on Chromium and it looked fine.

Instead of inheriting from parent which can vary.
@victorlin victorlin temporarily deployed to auspice-victorlin-focus-koraxw October 23, 2024 20:05 Inactive
@victorlin victorlin merged commit 7bb1245 into master Oct 23, 2024
26 checks passed
@victorlin victorlin deleted the victorlin/focus-toggle-placement branch October 23, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants