Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[preview 1] Move panel toggles to control headers #1707

Closed
wants to merge 9 commits into from
Closed

[preview 1] Move panel toggles to control headers #1707

wants to merge 9 commits into from

Commits on Oct 5, 2023

  1. panel-toggles: Rename for TypeScript conversion

    @victorlin
    victorlin committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    b8e82c3 View commit details
    Browse the repository at this point in the history

  2. panel-toggles: Convert to TypeScript 

    The hooks API is recommended by Redux docs¹.

¹ https://react-redux.js.org/api/hooks
    @victorlin
    victorlin committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    0615b36 View commit details
    Browse the repository at this point in the history

  3. panel-toggles: Add context to implicit behavior

    @victorlin
    victorlin committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    ec3423b View commit details
    Browse the repository at this point in the history

  4. annotatedHeader: Convert to TypeScript

    @victorlin
    victorlin committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    d7354d1 View commit details
    Browse the repository at this point in the history

  5. Move panel toggles to control headers 

    Do this by extending annotatedHeader to take an optional toggle, then
using it for all available panels.

Simplify headers and translations to just the panel name (e.g. Tree)
instead of "Show <panel name>" / "<panel name> Options".

Repurpose and move the section "Panel Options" to the top as "Layout".
Conditionally render that entire section including the header.
    @victorlin
    victorlin committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    16e680b View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2023

  1. simplify label empty string

    @victorlin
    victorlin committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    0166bf3 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2023

  1. Use separate styled component for font-related styles 

    This keeps the styling closer to where it is used.
    @victorlin
    victorlin committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    39e6d11 View commit details
    Browse the repository at this point in the history

  2. Add horizontal divider line

    @victorlin
    victorlin committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    8882e72 View commit details
    Browse the repository at this point in the history

  3. [wip] panel info icon on immediate right, toggle on far right

    @victorlin
    victorlin committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    80063fa View commit details
    Browse the repository at this point in the history