-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign panel sections in sidebar #1704
Commits on Nov 10, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 82d3883 - Browse repository at this point
Copy the full SHA 82d3883View commit details -
AnnotatedHeader: Convert to TypeScript
The component was written to allow tooltip as optional, so make that explicit. Other props should be required.
Configuration menu - View commit details
-
Copy full SHA for 1dd9bd8 - Browse repository at this point
Copy the full SHA 1dd9bd8View commit details -
AnnotatedHeader: Use separate styled component for font-related styles
This keeps the styling closer to where it is used.
Configuration menu - View commit details
-
Copy full SHA for 46ed345 - Browse repository at this point
Copy the full SHA 46ed345View commit details -
Make Language its own controls section
Previously, it looked like language was a part of Panel Options.
Configuration menu - View commit details
-
Copy full SHA for 620bfed - Browse repository at this point
Copy the full SHA 620bfedView commit details -
Determine panel visibility states in controls component
Instead of determining in the sidebar and passing down as props.
Configuration menu - View commit details
-
Copy full SHA for a0ebda5 - Browse repository at this point
Copy the full SHA a0ebda5View commit details -
tsconfig: Disable exactOptionalPropertyTypes
Disabling this makes typed prop drilling more readable by not requiring a conditional for optional props¹. ¹ https://stackoverflow.com/a/48816255
Configuration menu - View commit details
-
Copy full SHA for 8a96a09 - Browse repository at this point
Copy the full SHA 8a96a09View commit details -
Prepare for panel-specific header changes
Split AnnotatedHeader into AnnotatedTitle and ControlHeader. A future commit will introduce PanelHeader. This places the header info icon immediately to the right of the title, instead of the far right side (to make room for the upcoming panel visibility toggle).
Configuration menu - View commit details
-
Copy full SHA for ce518c5 - Browse repository at this point
Copy the full SHA ce518c5View commit details
Commits on Nov 13, 2023
-
Move panel toggles to control headers
Do this with some new panel-specific components that build upon the existing AnnotatedTitle and Toggle components. Simplify headers and translations to just the panel name (e.g. Tree) instead of "Show <panel name>" / "<panel name> Options". Conditionally render the entire "Panel Options" section including the header. This also adds a section for the entropy panel to maintain its toggle-ability. This is an empty section because it does not have any sidebar options.
Configuration menu - View commit details
-
Copy full SHA for e441dae - Browse repository at this point
Copy the full SHA e441daeView commit details -
Rename unselectedBackground to alternateBackground
This color is now used for more than just the unselected background.
Configuration menu - View commit details
-
Copy full SHA for 1ad4376 - Browse repository at this point
Copy the full SHA 1ad4376View commit details -
Rename "Panel Options" to "Display"
I chose the title "Display" even though it is called "layout" in the state because "Layout" is already used to describe tree layout, and I didn't want translations to conflict. I also contemplated putting this control at the top. However, its conditional rendering worsens usability upon toggling panel visibility, as the scroll position is changed due to its placement above the toggles.
Configuration menu - View commit details
-
Copy full SHA for 404e2d4 - Browse repository at this point
Copy the full SHA 404e2d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for e117e19 - Browse repository at this point
Copy the full SHA e117e19View commit details
Commits on Nov 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 41b8508 - Browse repository at this point
Copy the full SHA 41b8508View commit details -
Configuration menu - View commit details
-
Copy full SHA for beadef7 - Browse repository at this point
Copy the full SHA beadef7View commit details -
Configuration menu - View commit details
-
Copy full SHA for e018f30 - Browse repository at this point
Copy the full SHA e018f30View commit details