Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign panel sections in sidebar #1704

Merged
merged 14 commits into from
Nov 14, 2023
Merged

Commits on Nov 10, 2023

  1. Configuration menu
    Copy the full SHA
    82d3883 View commit details
    Browse the repository at this point in the history
  2. AnnotatedHeader: Convert to TypeScript

    The component was written to allow tooltip as optional, so make that
    explicit. Other props should be required.
    victorlin committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    1dd9bd8 View commit details
    Browse the repository at this point in the history
  3. AnnotatedHeader: Use separate styled component for font-related styles

    This keeps the styling closer to where it is used.
    victorlin committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    46ed345 View commit details
    Browse the repository at this point in the history
  4. Make Language its own controls section

    Previously, it looked like language was a part of Panel Options.
    victorlin committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    620bfed View commit details
    Browse the repository at this point in the history
  5. Determine panel visibility states in controls component

    Instead of determining in the sidebar and passing down as props.
    victorlin committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    a0ebda5 View commit details
    Browse the repository at this point in the history
  6. tsconfig: Disable exactOptionalPropertyTypes

    Disabling this makes typed prop drilling more readable by not requiring
    a conditional for optional props¹.
    
    ¹ https://stackoverflow.com/a/48816255
    victorlin committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    8a96a09 View commit details
    Browse the repository at this point in the history
  7. Prepare for panel-specific header changes

    Split AnnotatedHeader into AnnotatedTitle and ControlHeader. A future
    commit will introduce PanelHeader.
    
    This places the header info icon immediately to the right of the title,
    instead of the far right side (to make room for the upcoming panel
    visibility toggle).
    victorlin committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    ce518c5 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2023

  1. Move panel toggles to control headers

    Do this with some new panel-specific components that build upon the
    existing AnnotatedTitle and Toggle components.
    
    Simplify headers and translations to just the panel name (e.g. Tree)
    instead of "Show <panel name>" / "<panel name> Options".
    
    Conditionally render the entire "Panel Options" section including the
    header.
    
    This also adds a section for the entropy panel to maintain its
    toggle-ability. This is an empty section because it does not have any
    sidebar options.
    victorlin committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    e441dae View commit details
    Browse the repository at this point in the history
  2. Rename unselectedBackground to alternateBackground

    This color is now used for more than just the unselected background.
    victorlin committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    1ad4376 View commit details
    Browse the repository at this point in the history
  3. Rename "Panel Options" to "Display"

    I chose the title "Display" even though it is called "layout" in the
    state because "Layout" is already used to describe tree layout, and I
    didn't want translations to conflict.
    
    I also contemplated putting this control at the top. However, its
    conditional rendering worsens usability upon toggling panel visibility,
    as the scroll position is changed due to its placement above the
    toggles.
    victorlin committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    404e2d4 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e117e19 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2023

  1. Configuration menu
    Copy the full SHA
    41b8508 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    beadef7 View commit details
    Browse the repository at this point in the history
  3. Update changelog

    victorlin committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    e018f30 View commit details
    Browse the repository at this point in the history