Remove entropy font style injection #1694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 08952cf. The XML string replacement causes issues when the text element already has a class defined (multiple class attributes are not allowed). Remove the replacement entirely since similar styles are inherited from global.css¹. ¹ https://github.com/nextstrain/auspice/blob/8111de141aa3eba1e7b86638b7ae1b5b10ff6327/src/css/global.css#L3
nextstrain-bot
temporarily deployed
to
auspice-victorlin-fix-e-zwceq8
jameshadfield
approved these changes
Sep 6, 2023
There was a problem hiding this comment.
Ha! That's some quality parsing right there. Thanks @victorlin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This reverts commit 08952cf.
The XML string replacement causes issues when the text element already has a class defined (multiple class attributes are not allowed).
Remove the replacement entirely since similar styles are inherited from global.css:
auspice/src/css/global.css
Line 3 in 8111de1
Related issue(s)
Fixes #1695
Testing
- [ ] (to be done by a Nextstrain team member) Create preview PRs on downstream repositories.Small change, not necessary