Skip to content

Commit

Permalink
🚧 add note on re-focus w/ filter change
Browse files Browse the repository at this point in the history
  • Loading branch information
victorlin committed Oct 4, 2024
1 parent 4570011 commit 92b0560
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions src/actions/tree.js
Original file line number Diff line number Diff line change
Expand Up @@ -294,6 +294,7 @@ export const applyFilter = (mode, trait, values) => {
}
dispatch({type: types.APPLY_FILTER, trait, values: newValues});
dispatch(updateVisibleTipsAndBranchThicknesses());
// FIXME: re-focus with one of the above dispatches or new dispatch
};
};

Expand Down
1 change: 1 addition & 0 deletions src/components/tree/reactD3Interface/change.js
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ export const changePhyloTreeViaPropsComparison = (mainTree, phylotree, oldProps,
}

/* change treeFocus behavior */
// FIXME: updateLayout when filters have changed to re-focus
if (oldProps.treeFocus !== newProps.treeFocus) {
args.newTreeFocus = newProps.treeFocus;
args.updateLayout = true;
Expand Down

0 comments on commit 92b0560

Please sign in to comment.