Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: allow export to validate schema for a specific version of auspice #1326

Open
corneliusroemer opened this issue Sep 27, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@corneliusroemer
Copy link
Member

Context

I spent some time figuring out why tip_label default didn't work with Auspice.

Turns out that that feature was prematurely released in the auspice schema shipped with augur (#1299), before auspice supports that customization (see nextstrain/auspice#1692).

Description

While it's hopefully a one-off that augur's schema is ahead of auspice, it might be a good idea to allow validation against a range of auspice schema versions.

Use cases:

  • When you want the auspice.json to be compatible with old auspice versions, one could e.g. --schema-versions 2.38,2.47 to export telling it to check that the auspice.json is valid for both auspice versions 2.38 and 2.47. By default we could use always the latest version at the time of the augur release.

I'm not sure where we currently get schemas from, it might be cool if schemas could be downloaded dynamically, so that new auspice schemas can be validated by old auspice versions.

We might even be able to point to a schema on a PR, if one wants to test a new feature. Maybe this could help prevent the premature addition of a future auspice capability in augur.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant