Fix cache #23
Merged
Fix cache #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that even though files were update in ingest, the cache still didn't change and phylo did not run. Traced it back to incorrect S3 URLs leading to the use of the default hash in the cache. Output message to the GITHUB_STEP_SUMMARY so that we can immediately see if an S3 file doesn't have a sha256sum. <#22 (comment)>
This workflow was originally copied from lassa which included the `all` prefix. Removing the prefix to match the WNV S3 files so that the cache can work as expected and trigger the phylo workflow.
j23414
approved these changes
Oct 10, 2024
|
Phylo build was successfully uploaded and viewable at https://nextstrain.org/staging/WNV/genome |
|
Today's automated run worked as expected. I did want to note that the automated phylo workflow is still deploying to staging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Fixes the ingest-to-phylogenetic workflow cache.
Metadata.sha256sumfor an S3 file (example).Related issue(s)
Follow up to #22 (comment)
Checklist